Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check assets:precompile is defined before enhancing #59

Merged
merged 1 commit into from
Dec 31, 2021

Conversation

richardTowers
Copy link
Contributor

a749ca2 suggests that "Sprockets is not a dependency", so we should not
assume that the assets:precompile task will be defined. If it's not
there, we should just skip enhancing it.

Fixes #58

a749ca2 suggests that "Sprockets is not a dependency", so we should not
assume that the assets:precompile task will be defined. If it's not
there, we should just skip enhancing it.

Fixes rails#58
@dhh dhh merged commit a1d4c6b into rails:main Dec 31, 2021
@richardTowers richardTowers deleted the do-not-assume-sprockets-rake-tasks branch December 31, 2021 17:35
HLFH added a commit to HLFH/cssbundling-rails that referenced this pull request Jan 19, 2022
rails@a749ca2 suggests that "Sprockets is not a dependency", so we should not
assume that the assets:precompile AND assets:clobber tasks will be defined. If it's not
there, we should just skip enhancing it.

Related to: rails#59
@HLFH
Copy link
Contributor

HLFH commented Jan 19, 2022

Same issue for assets:clobber.

@dhh You can merge #71, close duplicate #72, and merge rails/jsbundling-rails#70 on jsbundling-rails project.

dhh pushed a commit that referenced this pull request Jan 28, 2022
a749ca2 suggests that "Sprockets is not a dependency", so we should not
assume that the assets:precompile AND assets:clobber tasks will be defined. If it's not
there, we should just skip enhancing it.

Related to: #59
patrickm68 added a commit to patrickm68/bundling-rails that referenced this pull request Dec 1, 2022
rails/cssbundling-rails@a749ca2 suggests that "Sprockets is not a dependency", so we should not
assume that the assets:precompile AND assets:clobber tasks will be defined. If it's not
there, we should just skip enhancing it.

Related to: rails/cssbundling-rails#59
smartech7 pushed a commit to smartech7/ruby-css-bundling that referenced this pull request Aug 4, 2023
rails/cssbundling-rails@a749ca2 suggests that "Sprockets is not a dependency", so we should not
assume that the assets:precompile AND assets:clobber tasks will be defined. If it's not
there, we should just skip enhancing it.

Related to: rails/cssbundling-rails#59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Don't know how to build task 'assets:precompile'" when used without sprockets
3 participants