Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for runtime specific option flags #36

Merged
merged 2 commits into from Apr 12, 2016
Merged

Allow for runtime specific option flags #36

merged 2 commits into from Apr 12, 2016

Conversation

josh
Copy link
Contributor

@josh josh commented Apr 12, 2016

An options hash is already part of the Context argument list, but isn't totally plumbed all the way through.

It'd be great if we passed the options all the way down. This would allow for implementation specific flags such as timeouts.

ExecJS.eval("superSlow()", timeout: 3)

CC: @rafaelfranca @guilleiguaran

@rails-bot
Copy link

r? @schneems

(@rails-bot has picked a reviewer for you, use r? to override)

@rafaelfranca
Copy link
Member

This looks good to me. But, is it a breaking change since if the custom runtime didn't accept options in the method it will raise an exception?

Do you want to merge or should I?

@schneems
Copy link
Member

Can we check arity and give some kind of warning or deprecation?

@josh
Copy link
Contributor Author

josh commented Apr 12, 2016

Can we check arity

Lets check arity, hopefully that doesn't cause any sort of overhead.

@guilleiguaran
Copy link
Member

👍

@guilleiguaran guilleiguaran merged commit 8f22894 into rails:master Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants