Update docs with pinning modules from engine/gem #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Rails ActionView includes rails-ujs.esm.js, we can import it directly without having to download the file from a CDN.
javierjulio
changed the title
|
Anyway, keep in mind this rails/rails#50535 |
|
It's happening automatically in new apps when you activate active storage or action text through the install app. But would be happy to see it specified somewhere. And yes, rails-ujs is gone, so wouldn't focus further on that. |
|
Solved in f27ec14. |
|
@dhh great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on ActiveAdmin v4 which uses importmap-rails (separate engine config) and @rails/ujs. I wondered why I had to download the @rails/ujs file from a CDN if the ESM version is already shipped in Rails (ActionView) to begin with. I figured it would help to have a section in the docs to demonstrate how to pin a module and link it, where the module file itself is included in Rails. My use case was for @rails/ujs but this approach should be applicable for activestorage, etc. I'm not sure if the term "vendored" here is appropriate. Would appreciate any review/corrections.