Update comment in controller generator templates #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2013 this comment was updated in rails/rails@3f9baeb to say "Only allow a trusted parameter "white list" through." but no one ever noticed that it didn't update in an app that used jbuilder. jbuilder uses the same generators as Rails and actually overrides them when you do a scaffold generator with jbuilder installed. That means that this comment had the old text since 2013. Oops. In #33681 we also stopped using "whitelist" in Rails so I've updated this text and the text in Rails to remove this reference. See rails/rails#37390
kaspth
approved these changes
Oct 7, 2019
carlosantoniodasilva
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2013 this comment was updated in
rails/rails@3f9baeb to say "Only allow
a trusted parameter "white list" through." but no one ever noticed that
it didn't update in an app that used jbuilder.
jbuilder uses the same generators as Rails and actually overrides them
when you do a scaffold generator with jbuilder installed. That means
that this comment had the old text since 2013. Oops.
In #33681 we also stopped using "whitelist" in Rails so I've updated
this text and the text in Rails to remove this reference. See
rails/rails#37390