New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove needless `webpack-cli` installing #96

Merged

dhh merged 1 commit into rails:main from y-yagi:fix-switch_from_webpacker

Feb 28, 2022

Member

y-yagi commented Feb 27, 2022

The webpack-cli was already installed by javascript:install:webpack that run atSetup jsbundling-rails section before.

jsbundling-rails/lib/install/webpack/install.rb

Line 3 in f71e756

run "yarn add webpack webpack-cli"

So you don't need to install at this point.


          Remove needless webpack-cli installing

3a2c766

The `webpack-cli` was already installed by
`javascript:install:webpack` that run at
`Setup jsbundling-rails` section before.
https://github.com/rails/jsbundling-rails/blob/f71e7564f6717a0cdacaa93c673360254d77b8e0/lib/install/webpack/install.rb#L3

So you don't need to install at this point.

dhh merged commit 493cd94 into rails:main

y-yagi deleted the fix-switch_from_webpacker branch

February 28, 2022 11:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment