Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack config tweak: name output sourcemaps after the output file with ext. #99

Merged
merged 1 commit into from Jun 18, 2022

Conversation

stevegeek
Copy link
Contributor

The following is a proposed change that could make the default webpack config slightly more generic.

It is a small tweak to the installed config that changes the sourceMapFilename template to [file].map.

This makes things easier if the config is expanded to include css extraction say.

For example, if mini-css-extract-plugin is used with css-loader / sass-loader then the resulting source map is named correctly (application.css.map for example) without having to realise/remember the sourceMapFilename needs changing.

@rstacruz
Copy link
Contributor

rstacruz commented Apr 5, 2022

This is a great idea!

@dhh dhh merged commit 0c8b321 into rails:main Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants