Account for time zones in DateTime serializations #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #101.
Overview
This PR fixes an issue with DateTime serializations where time zones could break string equality checks if DateTimes with differing time zones get serialized. As mentioned in the issue above, I was able to produce an error using the following in a Rails console:
After digging into the source code a bit, I realized that Kredis::Type::DateTime was always serializing to a string, which could produce different results for the same DateTime depending on the set time zone.
My proposed solution here is to convert DateTime instances to UTC before serialization so that strings get compared in the context of UTC. I thought this should be acceptable since it will still be able to read existing values from Redis without problem and perform operations on them.
The first commit produces a red test. The second commit gets it green.