Enum Bang setter #82
Merged
Enum Bang setter #82
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
reviewed
Mar 31, 2022
README.md
Outdated
| @@ -109,8 +109,8 @@ enum = Kredis.enum "myenum", values: %w[ one two three ], default: "one" | |||
| true == enum.one? # => GET myenum | |||
| enum.value = "two" # => SET myenum "two" | |||
| "two" == enum.value # => GET myenum | |||
| enum.value = "four" | |||
| "two" == enum.value # => GET myenum | |||
| enum.four! # => SET myenum "four" | |||
There was a problem hiding this comment.
Does it make sense that you can set the enum to a value which is not available in the values array?
There was a problem hiding this comment.
Good point. Thanks for the feedback. Updated the example.
There was a problem hiding this comment.
Hmmm. It's not a very nice exception when you try setting an invalid value.
jeremy
approved these changes
Apr 25, 2022
lewispb
added a commit
to lewispb/kredis
that referenced
this pull request
May 2, 2022
* main: Bump version for 1.2.0 Use pipeline for migration too Ensure to pass the pipeline to super Use block parameter to pipeline in Redis#multi (rails#68) Note tested / supported versions of Redis in the Readme (rails#79) Return counter value after incrementing/decrementing Enum Bang setter (rails#82) Add reset to Cycle after_change callbacks Add example in Readme.md Support configuring custom keys via method invocation Use bundle add instead (rails#81)
lewispb
added a commit
to lewispb/kredis
that referenced
this pull request
May 26, 2022
* main: Bump version for 1.2.0 Use pipeline for migration too Ensure to pass the pipeline to super Use block parameter to pipeline in Redis#multi (rails#68) Note tested / supported versions of Redis in the Readme (rails#79) Return counter value after incrementing/decrementing Enum Bang setter (rails#82) Add reset to Cycle after_change callbacks Add example in Readme.md Support configuring custom keys via method invocation Use bundle add instead (rails#81)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a bang method to set enums. This makes it function a bit more like the rails enums.