-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with api_only applications #87
base: main
Are you sure you want to change the base?
Conversation
This looks great!
I think this is ok, since this requires Rails 7+. I wouldn't worry too much about that. |
Thanks for the PR! It works fine for me so far but I've encountered one issue and I'm not quite sure if it's due to my setup or the PR here: I can't unpause a queue anymore. I'm a bloody beginner when it comes to Rails and especially Turbo still, so I'm unsure if the issue is due to my setup, the fact that I converted my Rails app to an API only app recently or something related to the PR here, so take it with a grain of salt: After pausing a queue (which works fine) it does update to button to show
If I manually send a
Lemme know if I can help and sorry in case it's not related to the PR here! |
This is an attempt to address #60 and make this gem work with API-only Rails applications without the need to change the host application.
I only tested it with a bare api_only application and my own non-api_only application and it seems to work, but we probably need more tests.
propshaft
as a dependency and required it (maybe we should conditionally require it based on if the host app already has any asset pipeline setup? can propshaft can cause issues with applications using Rails <7? Should we go for sprockets instead?)ActionController::Base
modules inApplicationController
, unless they're already included (maybe we should be more selective?)ApplicationController
, unless they're already includedActionDispatch::Flash
middleware if not already setup