Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct time zone for dates #99

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Intrepidd
Copy link
Contributor

ActiveJob::Core sets the enqueued_at property in UTC : https://github.com/rails/rails/blob/a2d2155e0ecdf18c469ccdfd28ca225fd7a42795/activejob/lib/active_job/core.rb#L119

Some other properties such as finished_at are set in the current time zone.

To make sure we compare times within the same time zone, this PR ensures all datetimes displayed are in_time_zone

@rosa
Copy link
Member

rosa commented Mar 27, 2024

Thanks @Intrepidd! I wonder if the best solution would be to ensure finished_at uses UTC as well 🤔 Since we show times like enqueued_at using UTC 🤔

@Intrepidd
Copy link
Contributor Author

This is up to the underlying adapter, for solid queue since it uses active record and will set created_at et al in the configured time zone, this makes sense to me to stay consistent.

But in any case we want to see times in our zone in Mission Control 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants