Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added docker logging driver and options #27

Closed
wants to merge 1 commit into from
Closed

added docker logging driver and options #27

wants to merge 1 commit into from

Conversation

azolf
Copy link
Contributor

@azolf azolf commented Jan 28, 2023

No description provided.

@azolf azolf mentioned this pull request Jan 28, 2023
Closed
@dhh
Copy link
Member

dhh commented Jan 31, 2023

Hmm. Think this is a little too low level. Lemme think about how best to expose. Also, need to have some sensible defaults.

@azolf
Copy link
Contributor Author

azolf commented Jan 31, 2023

Hmm. Think this is a little too low level. Lemme think about how best to expose. Also, need to have some sensible defaults.

Adding default values is easy, and we could put them there. also, we could define methods to use them as equivalent docker options.

@dhh
Copy link
Member

dhh commented Feb 9, 2023

Appreciate the work here, but I really like the simplicity of the local log driver. Great defaults, all we need. Done here: a80289d

@dhh dhh closed this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azolf @dhh