Warn on missing asset in compiler

rails · Nov 22, 2021 · 0d9a03a · 0d9a03a
1 parent 1d87136
commit 0d9a03a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/lib/propshaft/compilers/css_asset_urls.rb b/lib/propshaft/compilers/css_asset_urls.rb
@@ -11,7 +11,7 @@ def initialize(assembly)
   end
 
   def compile(logical_path, input)
-    input.gsub(ASSET_URL_PATTERN) { asset_url resolve_path(logical_path.dirname, $1) }
+    input.gsub(ASSET_URL_PATTERN) { asset_url resolve_path(logical_path.dirname, $1), logical_path, $1 }
   end
 
   private
@@ -25,11 +25,12 @@ def resolve_path(directory, filename)
       end
     end
 
-    def asset_url(resolved_path)
+    def asset_url(resolved_path, logical_path, pattern)
       if asset = assembly.load_path.find(resolved_path)
         %[url("#{assembly.config.prefix}/#{asset.digested_path}")]
       else
-        raise Propshaft::MissingAssetError.new(resolved_path)
+        Propshaft.logger.warn "Removed '#{pattern}' for missing asset '#{resolved_path}' in #{logical_path}"
+        %[url("")]
       end
     end
 end
diff --git a/test/propshaft/compilers/css_asset_urls_test.rb b/test/propshaft/compilers/css_asset_urls_test.rb
@@ -91,9 +91,8 @@ class Propshaft::Compilers::CssAssetUrlsTest < ActiveSupport::TestCase
   end
 
   test "missing asset" do
-    assert_raise Propshaft::MissingAssetError do
-      compile_asset_with_content(%({ background: url(missing.jpg); }))
-    end
+    compiled = compile_asset_with_content(%({ background: url('file-not-found.jpg'); }))
+    assert_match /{ background: url\(""\); }/, compiled
   end
 
   private