Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jean-François Labbé mapping #274

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Conversation

jean-francois-labbe
Copy link
Contributor

This commit is not linked to me rails/rails@90d5a5c Name is Jean-François Labbé

This one was linked: rails/rails@3491685 name is jean-francois labbe

@fxn
Copy link
Member

fxn commented Oct 17, 2023

Could you please remove the second "Jean-François Labbé" from the map call? the first argument is the canonical name, and the rest are existing aliases (different from the canonical name).

@jean-francois-labbe
Copy link
Contributor Author

Thanks for the explanation.
I fixed the mapping.

@fxn
Copy link
Member

fxn commented Oct 17, 2023

Thanks! I'll deploy soon.

@fxn fxn merged commit 178a0f4 into rails:master Oct 17, 2023
1 check passed
@fxn
Copy link
Member

fxn commented Oct 18, 2023

I've deployed but your name for some reason does not appear.

This is very strange, this application has been working routinely for years without any known flaw. I need to investigate. Don't worry, we'll figure it out and restore it.

@jean-francois-labbe
Copy link
Contributor Author

Thanks for the follow up.
Indeed it seems that some commits are missing.
Here are the PR on github https://github.com/rails/rails/pulls?q=is%3Apr+author%3Ajean-francois-labbe+is%3Aclosed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants