Make sure encoding changes don't break 1.8

rails · May 17, 2010 · 02c36cf · 02c36cf
1 parent 821e15e
commit 02c36cf
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/actionpack/lib/action_view/template/handlers/erb.rb b/actionpack/lib/action_view/template/handlers/erb.rb
@@ -7,7 +7,7 @@ module ActionView
   class OutputBuffer < ActiveSupport::SafeBuffer
     def initialize(*)
       super
-      encode!
+      encode! if encoding_aware?
     end
 
     def <<(value)
@@ -106,6 +106,8 @@ def compile(template)
             if !encoding && (template.source.encoding == Encoding::BINARY)
               raise WrongEncodingError.new(template_source, Encoding.default_external)
             end
+          else
+            erb = template.source.dup
           end
 
           result = self.class.erb_implementation.new(

diff --git a/actionpack/test/template/template_test.rb b/actionpack/test/template/template_test.rb
@@ -1,9 +1,11 @@
 require "abstract_unit"
 
-# These are the normal settings that will be set up by Railties
+if "ruby".encoding_aware?
-# TODO: Have these tests support other combinations of these values
+  # These are the normal settings that will be set up by Railties
-Encoding.default_internal = "UTF-8"
+  # TODO: Have these tests support other combinations of these values
-Encoding.default_external = "UTF-8"
+  Encoding.default_internal = "UTF-8"
+  Encoding.default_external = "UTF-8"
+end
 
 class TestERBTemplate < ActiveSupport::TestCase
   ERBHandler = ActionView::Template::Handlers::ERB