Skip to content

Commit

Permalink
Restore implicit rendering for XHR requests that want a HTML template [
Browse files Browse the repository at this point in the history
…#1590 state:resolved]
  • Loading branch information
josh committed Jan 27, 2009
1 parent f17c876 commit 093f758
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 0 deletions.
3 changes: 3 additions & 0 deletions actionpack/lib/action_view/paths.rb
Expand Up @@ -45,6 +45,9 @@ def find_template(original_template_path, format = nil)
return template
elsif template = load_path[template_path]
return template
# Try to find html version if the format is javascript
elsif format == :js && template = load_path["#{template_path}.html"]

This comment has been minimized.

Copy link
@josevalim

josevalim Jan 27, 2009

Contributor

You should set the contenty type to html in such cases, shouldn’t you? Otherwise it will respond as js.

return template
end
end

Expand Down
8 changes: 8 additions & 0 deletions actionpack/test/controller/render_test.rb
Expand Up @@ -274,6 +274,9 @@ def render_implicit_html_template
def render_explicit_html_template
end

def render_implicit_html_template_from_xhr_request
end

def formatted_html_erb
end

Expand Down Expand Up @@ -1010,6 +1013,11 @@ def test_explicitly_rendering_an_html_template_with_implicit_html_template_rende
end
end

def test_should_implicitly_render_html_template_from_xhr_request
get :render_implicit_html_template_from_xhr_request, :format => :js
assert_equal "Hello HTML!", @response.body
end

def test_should_render_formatted_template
get :formatted_html_erb
assert_equal 'formatted html erb', @response.body
Expand Down
@@ -0,0 +1 @@
Hello HTML!

0 comments on commit 093f758

Please sign in to comment.