Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #560 from guilleiguaran/fix_pluralize_table_names_…
…false Fixing has_many when ActiveRecord::Base.pluralize_table_names is false
- Loading branch information
Showing
4 changed files
with
19 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
class Aircraft < ActiveRecord::Base | ||
has_many :engines, :foreign_key => "car_id" | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2033ff8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guys, this broke active record test suite. Could you please take a look?
2033ff8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josevalim As we discussed the tests are looking okay for me (I ran
rake isolated_test_mysql
successfully). I haven't been able to try oracle because my install is fucked (I run it rarely and have upgraded my OS since last time). I also have very little time in the next few days. If this is a blocker for the RC then I suggest a revert for now, but I'll let you decide.2033ff8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries man! Better to just ping oracle guys to take a look into? Maybe it would be easy to @tenderlove to do it?