Skip to content

Commit

Permalink
refactor Journey::Routes
Browse files Browse the repository at this point in the history
* prefer do-end for multiline blocks
* prefer or-equals over returns with checks
  • Loading branch information
goshacmd committed Jan 6, 2013
1 parent 807e176 commit 2467ec8
Showing 1 changed file with 11 additions and 12 deletions.
23 changes: 11 additions & 12 deletions actionpack/lib/action_dispatch/journey/routes.rb
Expand Up @@ -33,24 +33,23 @@ def clear
end

def partitioned_routes
@partitioned_routes ||= routes.partition { |r|
r.path.anchored && r.ast.grep(Nodes::Symbol).all? { |n| n.default_regexp? }
}
@partitioned_routes ||= routes.partition do |r|
r.path.anchored && r.ast.grep(Nodes::Symbol).all?(&:default_regexp?)
end
end

def ast
return @ast if @ast
return if partitioned_routes.first.empty?

asts = partitioned_routes.first.map { |r| r.ast }
@ast = Nodes::Or.new(asts)
@ast ||= begin
asts = partitioned_routes.first.map(&:ast)
Nodes::Or.new(asts) unless asts.empty?
end
end

def simulator
return @simulator if @simulator

gtg = GTG::Builder.new(ast).transition_table
@simulator = GTG::Simulator.new(gtg)
@simulator ||= begin
gtg = GTG::Builder.new(ast).transition_table
GTG::Simulator.new(gtg)
end
end

# Add a route to the routing table.
Expand Down

0 comments on commit 2467ec8

Please sign in to comment.