Job worker thread logs failed jobs too

rails · Oct 26, 2012 · 26f52b2 · 26f52b2
1 parent 411378e
commit 26f52b2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/activesupport/lib/active_support/queueing.rb b/activesupport/lib/active_support/queueing.rb
@@ -96,7 +96,7 @@ def run(job)
     end
 
     def handle_exception(job, exception)
-      @logger.error "Job Error: #{exception.message}\n#{exception.backtrace.join("\n")}"
+      @logger.error "Job Error: #{job.inspect}\n#{exception.message}\n#{exception.backtrace.join("\n")}"
     end
   end
 end
diff --git a/activesupport/test/queueing/threaded_consumer_test.rb b/activesupport/test/queueing/threaded_consumer_test.rb
@@ -68,7 +68,7 @@ def teardown
     @queue.drain
 
     assert_equal 1, @logger.logged(:error).size
-    assert_match 'Job Error: RuntimeError: Error!', @logger.logged(:error).last
+    assert_match "Job Error: #{job.inspect}\nRuntimeError: Error!", @logger.logged(:error).last
   end
 
   test "logger defaults to stderr" do