avoid array allocation when extracting usernames and passwords

rails · May 13, 2014 · 325c9d5 · carlosantoniodasilva · May 13, 2014 · pixeltrix
1 parent 890a189
commit 325c9d5
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/actionpack/lib/action_dispatch/routing/route_set.rb b/actionpack/lib/action_dispatch/routing/route_set.rb
@@ -654,7 +654,13 @@ def _generate_prefix(options = {})
       def url_for(options)
         options = default_url_options.merge(options || {})
 
-        user, password = extract_authentication(options)
+        user = password = nil
+
+        if options[:user] && options[:password]
+          user     = options.delete :user
+          password = options.delete :password
+        end
+
         recall  = options.delete(:_recall)
 
         original_script_name = options.delete(:original_script_name).presence