Skip to content

Commit

Permalink
Don't need response prepare!
Browse files Browse the repository at this point in the history
  • Loading branch information
josh committed Dec 18, 2009
1 parent 44fb54f commit 3b44f35
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions actionpack/test/dispatch/response_test.rb
Expand Up @@ -7,7 +7,6 @@ def setup

test "simple output" do
@response.body = "Hello, World!"
@response.prepare!

status, headers, body = @response.to_a
assert_equal 200, status
Expand All @@ -25,7 +24,6 @@ def setup

test "utf8 output" do
@response.body = [1090, 1077, 1089, 1090].pack("U*")
@response.prepare!

status, headers, body = @response.to_a
assert_equal 200, status
Expand All @@ -41,7 +39,6 @@ def setup
@response.body = Proc.new do |response, output|
5.times { |n| output.write(n) }
end
@response.prepare!

status, headers, body = @response.to_a
assert_equal 200, status
Expand All @@ -59,22 +56,19 @@ def setup
test "content type" do
[204, 304].each do |c|
@response.status = c.to_s
@response.prepare!
status, headers, body = @response.to_a
assert !headers.has_key?("Content-Type"), "#{c} should not have Content-Type header"
end

[200, 302, 404, 500].each do |c|
@response.status = c.to_s
@response.prepare!
status, headers, body = @response.to_a
assert headers.has_key?("Content-Type"), "#{c} did not have Content-Type header"
end
end

test "does not include Status header" do
@response.status = "200 OK"
@response.prepare!
status, headers, body = @response.to_a
assert !headers.has_key?('Status')
end
Expand Down Expand Up @@ -114,13 +108,11 @@ def setup

test "cookies" do
@response.set_cookie("user_name", :value => "david", :path => "/")
@response.prepare!
status, headers, body = @response.to_a
assert_equal "user_name=david; path=/", headers["Set-Cookie"]
assert_equal({"user_name" => "david"}, @response.cookies)

@response.set_cookie("login", :value => "foo&bar", :path => "/", :expires => Time.utc(2005, 10, 10,5))
@response.prepare!
status, headers, body = @response.to_a
assert_equal "user_name=david; path=/\nlogin=foo%26bar; path=/; expires=Mon, 10-Oct-2005 05:00:00 GMT", headers["Set-Cookie"]
assert_equal({"login" => "foo&bar", "user_name" => "david"}, @response.cookies)
Expand Down

0 comments on commit 3b44f35

Please sign in to comment.