memoize calculated ip without additional variable

There is no need in additional `@calculated_ip` instance variable.
rails · Nov 1, 2012 · 43aa2d3 · 43aa2d3
1 parent 694334c
commit 43aa2d3
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/actionpack/lib/action_dispatch/middleware/remote_ip.rb b/actionpack/lib/action_dispatch/middleware/remote_ip.rb
@@ -63,9 +63,9 @@ class GetIp
       }x
 
       def initialize(env, middleware)
-        @env           = env
+        @env        = env
-        @middleware    = middleware
+        @middleware = middleware
-        @calculated_ip = false
+        @ip         = nil
       end
 
       # Determines originating IP address. REMOTE_ADDR is the standard
@@ -100,9 +100,7 @@ def calculate_ip
       end
 
       def to_s
-        return @ip if @calculated_ip
+        @ip ||= calculate_ip
-        @calculated_ip = true
-        @ip = calculate_ip
       end
 
       private