Skip to content

Commit

Permalink
Unused methods, module, etc.
Browse files Browse the repository at this point in the history
  • Loading branch information
amatsuda committed Jan 24, 2013
1 parent b7b27fc commit 4e05bfb
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 28 deletions.
8 changes: 0 additions & 8 deletions activerecord/test/models/company_in_module.rb
Expand Up @@ -71,14 +71,6 @@ class Account < ActiveRecord::Base
i.belongs_to :nested_qualified_billing_firm, :class_name => 'MyApplication::Billing::Nested::Firm'
i.belongs_to :nested_unqualified_billing_firm, :class_name => 'Nested::Firm'
end

validate :check_empty_credit_limit

protected

def check_empty_credit_limit
errors.add_on_empty "credit_limit"
end
end
end
end
8 changes: 0 additions & 8 deletions activerecord/test/models/person.rb
Expand Up @@ -91,14 +91,6 @@ class NestedPerson < ActiveRecord::Base

has_one :best_friend, :class_name => 'NestedPerson', :foreign_key => :best_friend_id
accepts_nested_attributes_for :best_friend, :update_only => true

def comments=(new_comments)
raise RuntimeError
end

def best_friend_first_name=(new_name)
assign_attributes({ :best_friend_attributes => { :first_name => new_name } })
end
end

class Insure
Expand Down
3 changes: 0 additions & 3 deletions activerecord/test/models/task.rb
@@ -1,5 +1,2 @@
class Task < ActiveRecord::Base
def updated_at
ending
end
end
9 changes: 0 additions & 9 deletions activerecord/test/models/topic.rb
Expand Up @@ -26,12 +26,6 @@ def call
end
}.new(self)

module NamedExtension
def two
2
end
end

has_many :replies, :dependent => :destroy, :foreign_key => "parent_id"
has_many :approved_replies, -> { approved }, class_name: 'Reply', foreign_key: "parent_id", counter_cache: 'replies_count'
has_many :replies_with_primary_key, :class_name => "Reply", :dependent => :destroy, :primary_key => "title", :foreign_key => "parent_title"
Expand Down Expand Up @@ -108,9 +102,6 @@ class ImportantTopic < Topic
end

class BlankTopic < Topic
def blank?
true
end

This comment has been minimized.

Copy link
@carlosantoniodasilva

carlosantoniodasilva Jan 24, 2013

Member

I think this one was added for a reason? To check that blank? true wouldn't break? 8424d0d

This comment has been minimized.

Copy link
@rafaelfranca

rafaelfranca Jan 24, 2013

Member

Yes. Please revert

This comment has been minimized.

Copy link
@rafaelfranca

rafaelfranca Jan 24, 2013

Member

Also it would be nice to add a comment, so it will not be removed again

This comment has been minimized.

Copy link
@amatsuda

amatsuda Jan 24, 2013

Author Member

Hrm. To me it seems like this blank? is not actually called. But alright, I'll revert this anyway.

This comment has been minimized.

Copy link
@amatsuda

amatsuda Jan 24, 2013

Author Member

Ahh. I understand.:bulb: This blank? would not be called but needs to be there.

This comment has been minimized.

Copy link
@rafaelfranca

rafaelfranca Jan 24, 2013

Member

Yes. It is not called since the bug was fixed. See https://github.com/rails/rails/pull/8204/files

end

module Web
Expand Down

0 comments on commit 4e05bfb

Please sign in to comment.