Skip to content

Commit

Permalink
Gist URLs are now namespaced
Browse files Browse the repository at this point in the history
  • Loading branch information
amatsuda committed Feb 18, 2013
1 parent b04c81d commit 57b0ae8
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion actionpack/lib/action_dispatch/middleware/remote_ip.rb
Expand Up @@ -83,7 +83,7 @@ class GetIp

# This constant contains a regular expression that validates every known
# form of IP v4 and v6 address, with or without abbreviations, adapted
# from {this gist}[https://gist.github.com/1289635].
# from {this gist}[https://gist.github.com/gazay/1289635].
VALID_IP = %r{
(^(25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[0-9]{1,2})(\.(25[0-5]|2[0-4][0-9]|1[0-9][0-9]|[0-9]{1,2})){3}$) | # ip v4
(^(
Expand Down
2 changes: 1 addition & 1 deletion activerecord/lib/active_record/attribute_methods/read.rb
Expand Up @@ -74,7 +74,7 @@ def cacheable_column?(column)
# to a date object, like Date.new(2004, 12, 12)).
def read_attribute(attr_name)
# If it's cached, just return it
# We use #[] first as a perf optimization for non-nil values. See https://gist.github.com/3552829.
# We use #[] first as a perf optimization for non-nil values. See https://gist.github.com/jonleighton/3552829.
name = attr_name.to_s
@attributes_cache[name] || @attributes_cache.fetch(name) {
column = @columns_hash.fetch(name) {
Expand Down
Expand Up @@ -577,10 +577,10 @@ def remove_connection(owner)
# When a connection is established or removed, we invalidate the cache.
#
# Ideally we would use #fetch here, as class_to_pool[klass] may sometimes be nil.
# However, benchmarking (https://gist.github.com/3552829) showed that #fetch is
# significantly slower than #[]. So in the nil case, no caching will take place,
# but that's ok since the nil case is not the common one that we wish to optimise
# for.
# However, benchmarking (https://gist.github.com/jonleighton/3552829) showed that
# #fetch is significantly slower than #[]. So in the nil case, no caching will
# take place, but that's ok since the nil case is not the common one that we wish
# to optimise for.
def retrieve_connection_pool(klass)
class_to_pool[klass.name] ||= begin
until pool = pool_for(klass)
Expand Down
2 changes: 1 addition & 1 deletion guides/source/generators.md
Expand Up @@ -412,7 +412,7 @@ This command will generate the `Thud` application, and then apply the template t
Templates don't have to be stored on the local system, the `-m` option also supports online templates:

```bash
$ rails new thud -m https://gist.github.com/722911.txt
$ rails new thud -m https://gist.github.com/radar/722911/raw/
```

Whilst the final section of this guide doesn't cover how to generate the most awesome template known to man, it will take you through the methods available at your disposal so that you can develop it yourself. These same methods are also available for generators.
Expand Down
2 changes: 1 addition & 1 deletion guides/source/kindle/KINDLE.md
Expand Up @@ -10,7 +10,7 @@
## Resources

* [Stack Overflow: Kindle Periodical Format](http://stackoverflow.com/questions/5379565/kindle-periodical-format)
* Example Periodical [.ncx](https://gist.github.com/808c971ed087b839d462) and [.opf](https://gist.github.com/d6349aa8488eca2ee6d0)
* Example Periodical [.ncx](https://gist.github.com/mipearson/808c971ed087b839d462) and [.opf](https://gist.github.com/mipearson/d6349aa8488eca2ee6d0)
* [Kindle Publishing Guidelines](http://kindlegen.s3.amazonaws.com/AmazonKindlePublishingGuidelines.pdf)
* [KindleGen & Kindle Previewer](http://www.amazon.com/gp/feature.html?ie=UTF8&docId=1000234621)

Expand Down
6 changes: 3 additions & 3 deletions railties/test/generators/shared_generator_tests.rb
Expand Up @@ -83,7 +83,7 @@ def test_template_raises_an_error_with_invalid_path
end

def test_template_is_executed_when_supplied
path = "http://gist.github.com/103208.txt"
path = "https://gist.github.com/josevalim/103208/raw/"
template = %{ say "It works!" }
template.instance_eval "def read; self; end" # Make the string respond to read

Expand All @@ -92,7 +92,7 @@ def test_template_is_executed_when_supplied
end

def test_template_is_executed_when_supplied_an_https_path
path = "https://gist.github.com/103208.txt"
path = "https://gist.github.com/josevalim/103208/raw/"
template = %{ say "It works!" }
template.instance_eval "def read; self; end" # Make the string respond to read

Expand Down Expand Up @@ -188,7 +188,7 @@ def test_builder_option_with_tweak_plugin_builder
end

def test_builder_option_with_http
url = "http://gist.github.com/103208.txt"
url = "https://gist.github.com/josevalim/103208/raw/"
template = "class #{builder_class}; end"
template.instance_eval "def read; self; end" # Make the string respond to read

Expand Down

0 comments on commit 57b0ae8

Please sign in to comment.