Stopped logging template compiles as it only clogs up the log

rails · Sep 10, 2008 · 6233628 · 6233628
1 parent dc8b21d
commit 6233628
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/actionpack/CHANGELOG b/actionpack/CHANGELOG
@@ -1,5 +1,7 @@
 *Edge*
 
+* Stopped logging template compiles as it only clogs up the log [DHH]
+
 * Changed the X-Runtime header to report in milliseconds [DHH]
 
 * Changed BenchmarkHelper#benchmark to report in milliseconds [DHH]

diff --git a/actionpack/lib/action_view/renderable.rb b/actionpack/lib/action_view/renderable.rb
@@ -72,12 +72,9 @@ def #{render_symbol}(local_assigns)
         end_src
 
         begin
-          logger = defined?(ActionController) && Base.logger
-          logger.debug "Compiling template #{render_symbol}" if logger
-
           ActionView::Base::CompiledTemplates.module_eval(source, filename, 0)
         rescue Exception => e # errors from template code
-          if logger
+          if logger = defined?(ActionController) && Base.logger
             logger.debug "ERROR: compiling #{render_symbol} RAISED #{e}"
             logger.debug "Function body: #{source}"
             logger.debug "Backtrace: #{e.backtrace.join("\n")}"