Merge pull request #12091 from rywall/pluck-optimization

[Perf] Don't use Enumerable#next in pluck since it is very slow
rails · Aug 31, 2013 · 6617437 · 6617437
2 parents 92c35ad + 8467be9
commit 6617437
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/activerecord/lib/active_record/relation/calculations.rb b/activerecord/lib/active_record/relation/calculations.rb
@@ -161,8 +161,7 @@ def pluck(*column_names)
         result = result.map do |attributes|
           values = klass.initialize_attributes(attributes).values
 
-          iter = columns.each
+          columns.zip(values).map { |column, value| column.type_cast value }
-          values.map { |value| iter.next.type_cast value }
         end
         columns.one? ? result.map!(&:first) : result
       end