Fixed that the create_x method from belongs_to wouldn't save the asso…

…ciation properly #2042 [Florian Weber] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2279 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
rails · Sep 20, 2005 · 66ecf31 · 66ecf31
1 parent 5213a1f
commit 66ecf31
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/activerecord/CHANGELOG b/activerecord/CHANGELOG
@@ -1,5 +1,7 @@
 *SVN*
 
+* Fixed that the create_x method from belongs_to wouldn't save the association properly #2042 [Florian Weber]
+
 * Fixed saving a record with two unsaved belongs_to associations pointing to the same object #2023 [Tobias Luetke]
 
 * Improved migrations' behavior when the schema_info table is empty. [Nicholas Seckar]

diff --git a/activerecord/lib/active_record/associations/belongs_to_association.rb b/activerecord/lib/active_record/associations/belongs_to_association.rb
@@ -13,8 +13,8 @@ def reset
       end
 
       def create(attributes = {})
-        record = build(attributes)
+        record = @association_class.create(attributes)
-        record.save
+        replace(record, true)
         record
       end
 

diff --git a/activerecord/test/associations_test.rb b/activerecord/test/associations_test.rb
@@ -664,6 +664,9 @@ def test_creating_the_belonging_object
     citibank = Account.create("credit_limit" => 10)
     apple    = citibank.create_firm("name" => "Apple")
     assert_equal apple, citibank.firm
+    citibank.save
+    citibank.reload
+    assert_equal apple, citibank.firm
   end
 
   def test_building_the_belonging_object