Skip to content

Commit

Permalink
allow people to set a local .Gemfile so that things like ruby-debug a…
Browse files Browse the repository at this point in the history 
…re not required for regular development
  • Loading branch information
@tenderlove
tenderlove committed Nov 17, 2011
1 parent d57d809 commit a437986
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
1 change: 1 addition & 0 deletions .gitignore
View file
Expand Up @@ -2,6 +2,7 @@
# Check out http://help.github.com/ignore-files/ for how to set that up.

debug.log
.Gemfile
/.bundle
/.rbenv-version
/.rvmrc
Expand Down
7 changes: 2 additions & 5 deletions Gemfile
View file
Expand Up @@ -36,13 +36,11 @@ gem "memcache-client", ">= 1.8.5"

platforms :mri_18 do
gem "system_timer"
gem "ruby-debug", ">= 0.10.3" unless ENV['TRAVIS']
gem "json"
end

platforms :mri_19 do
gem "ruby-debug19", :require => "ruby-debug" unless ENV['TRAVIS'] || RUBY_VERSION >= "2.0"
end
# Add your own local bundler stuff
instance_eval File.read ".Gemfile" if File.exists? ".Gemfile"

platforms :mri do
group :test do
Expand All @@ -69,7 +67,6 @@ platforms :ruby do
end

platforms :jruby do
gem "ruby-debug", ">= 0.10.3"
gem "json"
gem "activerecord-jdbcsqlite3-adapter", ">= 1.2.0"

Expand Down

6 comments on commit a437986

@indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wycats, @hone, thoughts on making .Gemfile a built-in convention?

@fxn
Copy link
Member

@fxn fxn commented on a437986 Nov 18, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that coherent with the problem bundler solves? if you include an arbitrary private .Gemfile your dependency tree is in the general case unrelated to the one of the project.

@indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... yes. At a minimum, it only works with projects that don't check in their Gemfile.lock, because suddenly everyone has a different one. But everyone already had a different one on this project, because of (for example) conditionals in the Gemfile.

@josevalim
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems bad to make this a general practice. It (may) make sense for Rails to not version Gemfile.lock, but I personally advocate that as a bad practice to the majority of projects.

@indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, any project that is a gem is not supposed to version Gemfile.lock, according to Yehuda :P

@josevalim
Copy link
Contributor

@josevalim josevalim commented on a437986 Nov 18, 2011 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.