Raise an exception when unserialization fails due to a missing class

rails · Mar 28, 2013 · a474396 · a474396
1 parent 51ba66b
commit a474396
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/activerecord/lib/active_record/coders/yaml_column.rb b/activerecord/lib/active_record/coders/yaml_column.rb
@@ -33,7 +33,8 @@ def load(yaml)
           obj ||= object_class.new if object_class != Object
 
           obj
-        rescue ArgumentError, Psych::SyntaxError
+        rescue ArgumentError , Psych::SyntaxError => e
+          raise if e.to_s =~ /undefined class/
           yaml
         end
       end

diff --git a/activerecord/test/cases/coders/yaml_column_test.rb b/activerecord/test/cases/coders/yaml_column_test.rb
@@ -48,6 +48,14 @@ def test_load_swallows_yaml_exceptions
         bad_yaml = '--- {'
         assert_equal bad_yaml, coder.load(bad_yaml)
       end
+
+      def test_load_doesnt_handle_undefined_class_or_module
+        coder = YAMLColumn.new
+        missing_class_yaml = '--- !ruby/object:DoesNotExistAndShouldntEver {}\n'
+        assert_raises(ArgumentError) do
+          coder.load(missing_class_yaml)
+        end
+      end
     end
   end
 end