Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix "last equality wins" logic in relation merge
This is a real fix (as compared to the band-aid in b127d86), which uses the recently-added equality methods for ARel nodes. It has the side benefit of simplifying the merge code a bit.
- Loading branch information
Showing
2 changed files
with
12 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf80522
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ernie why is there "last equality wins" logic anyways? If a users generates a query with
WHERE column = 1 AND column = 2
, why not let it return no records? This is related to my question/bug #6596.bf80522
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.