make sure we keep parent records in order

rails · Nov 6, 2010 · c11102d · c11102d
1 parent 39a8056
commit c11102d
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/activerecord/lib/active_record/associations.rb b/activerecord/lib/active_record/associations.rb
@@ -1873,15 +1873,15 @@ def count_aliases_from_table_joins(name)
 
           def instantiate(rows)
             primary_key = join_base.aliased_primary_key
-            base_records_hash = {}
+            parents = {}
 
-            rows.each do |model|
+            records = rows.map { |model|
               primary_id = model[primary_key]
-              base_records_hash[primary_id] ||= join_base.instantiate(model)
+              parent = parents[primary_id] ||= join_base.instantiate(model)
-              construct(base_records_hash[primary_id], @associations, join_associations.dup, model)
+              construct(parent, @associations, join_associations.dup, model)
-            end
+              parent
+            }.uniq
 
-            records = base_records_hash.values
             remove_duplicate_results!(join_base.active_record, records, @associations)
             records
           end