Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused comma after loop variable #10076

Merged
merged 2 commits into from Apr 4, 2013

Conversation

choudhuryanupam
Copy link

Removed unused comma after loop variable in the test case.

@@ -24,7 +24,7 @@ def each
def test_group_by
names = %w(marcel sam david jeremy)
klass = Struct.new(:name)
objects = (1..50).inject([]) do |people,|
objects = (1..50).inject([]) do |people|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change it to use map instead of inject + []?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlosantoniodasilva Sure...doing right away

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlosantoniodasilva Replaced inject with map. Please check.

rafaelfranca added a commit that referenced this pull request Apr 4, 2013
Removed unused comma after loop variable
@rafaelfranca rafaelfranca merged commit a137580 into rails:master Apr 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants