Extract method declaration regexp for assert_method into a constant #10194

pabloh · 2013-04-12T18:47:12Z

No description provided.

carlosantoniodasilva · 2013-04-12T21:41:15Z

railties/lib/rails/generators/testing/assertions.rb

@@ -2,6 +2,8 @@ module Rails
  module Generators
    module Testing
      module Assertions
+        METHOD_DECLARATION_REGEXP = /(\s+)def #{method}(\(.+\))?(.*?)\n\1end/m


I think that _REGEXP doesn't need to be part of the constant name, wdyt?

…sting_assertion Extract method declaration regexp for assert_method into a constant

…ators_testing_assertion" This reverts commit 81f2433, reversing changes made to c7673b0.

Extract method declaration regexp into a constant

83d0232

carlosantoniodasilva reviewed Apr 12, 2013
View reviewed changes

carlosantoniodasilva added a commit that referenced this pull request Apr 12, 2013

Merge pull request #10194 from pabloh/extract_regexp_at_generators_te…

81f2433

…sting_assertion Extract method declaration regexp for assert_method into a constant

carlosantoniodasilva merged commit 81f2433 into rails:master Apr 12, 2013

carlosantoniodasilva added a commit that referenced this pull request Apr 13, 2013

Revert "Merge pull request #10194 from pabloh/extract_regexp_at_gener…

334e260

…ators_testing_assertion" This reverts commit 81f2433, reversing changes made to c7673b0.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extract method declaration regexp for assert_method into a constant #10194

Extract method declaration regexp for assert_method into a constant #10194

pabloh commented Apr 12, 2013

carlosantoniodasilva Apr 12, 2013

Extract method declaration regexp for assert_method into a constant #10194

Extract method declaration regexp for assert_method into a constant #10194

Conversation

pabloh commented Apr 12, 2013

carlosantoniodasilva Apr 12, 2013

Choose a reason for hiding this comment