Adding a local thread registry to store local caches. #10250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -151,16 +168,16 @@ def thread_local_key | |||
| end | |||
|
|
|||
| def local_cache | |||
| Thread.current[thread_local_key] | |||
There was a problem hiding this comment.
Can we rename this thread_local_key to local_cache_key?
There was a problem hiding this comment.
Just renamed it, thanks!
rafaelfranca
added a commit
that referenced
this pull request
Apr 17, 2013
Adding a local thread registry to store local caches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a registry to store local caches. This should decrease the number of thread locals a lot because currently, every time you create a new local cache, you create a new thread local.
I'm using the
PerThreadRegistrymodule to create a single registry object.