Permitting arrays within a hash in strong_parameters #10319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: rails/strong_parameters#121 When params was of the form { :book => { :authors_attributes => { :'0' => ['William Shakespeare', '52'], :'1' => ['Unattributed Assistant'] } } } And its corresponding filter was { :book => { :authors_attributes => { :'0' => [], :'1' => [] } } } It resulted in params looking like this { :book => { :authors_attributes => { :'0' => nil, :'1' => nil } } } This was due to the way hashes with all numeric keys are treated. I just added a special case when a corresponding filter exists and is an empty array.
|
Please watch this thread before applying: rails/strong_parameters#121 (comment). |
simonc
referenced
this pull request
in simonc/strong_parameters
Aug 16, 2013
When params was of the form
{
:book => {
:authors_attributes => {
:'0' => ['William Shakespeare', '52'],
:'1' => ['Unattributed Assistant']
}
}
}
And its corresponding filter was
{
:book => {
:authors_attributes => {
:'0' => [],
:'1' => []
}
}
}
It resulted in params looking like this
{
:book => {
:authors_attributes => {
:'0' => nil,
:'1' => nil
}
}
}
This was due to the way hashes with all numeric keys are treated.
I just added a special case when a corresponding filter exists and is an empty
array.
|
Is this issue fixed by #12293 ? |
|
Yes, it seems that it was fixed. rails/actionpack/test/controller/parameters/nested_parameters_test.rb Lines 133 to 152 in f6797a7 This should probably be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: rails/strong_parameters#121