Delegation method bug #10347
Merged
Delegation method bug #10347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # @bar = bar | ||
| # end | ||
| # | ||
| # delegate :name, ro: :@bar |
There was a problem hiding this comment.
Typo - should be to: :@bar
|
@lellisga thanks for this! |
|
@pixeltrix thanks to you. This is ready |
| @@ -171,6 +171,11 @@ def test_delegation_with_allow_nil_and_nil_value | |||
| assert_nil rails.name | |||
| end | |||
|
|
|||
| def test_delegation_with_allow_nil_and_invalid_value | |||
| rails = Project.new("Rails", "David") | |||
| assert_raise(NoMethodError) { rails.name } | |||
There was a problem hiding this comment.
guille <3 <3 u didn't ping me "faltón" 👎
Add documentation and test to delegation method that make sure we're aware that when a delegated object is not nil or false and doesn't respond to the method it will still raise a NoMethodError exception.
|
Followup: see my comment here. |
fxn
added a commit
that referenced
this pull request
Apr 26, 2013
… true, and avoids multiple evaluation of the target method Notes: 1) I hope nilness is a word. 2) See rationale for avoiding multiple evaluation in a comment in the patch, credit goes to @jeremy for pointing out this gotcha in the existing implementation. 3) Embeds a little joke dedicated to @pixeltrix (it could be worse! :D). References #10347.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation and test to delegation method that make sure we're
aware that when a delegated object is not nil or false and doesn't
respond to the method it will still raise a NoMethodError exception.