Allow override of PostgreSQL UUID primary key default #10404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def primary_key(name, type = :primary_key, options = {}) | ||
| return super unless type == :uuid | ||
| options[:default] ||= 'uuid_generate_v4()' |
There was a problem hiding this comment.
Maybe
options[:default] = options.fetch(:default, 'uuid_generate_v4()')
|
Thank you so much. Your patch is very good. Congratulations for the nice documentation. I did some stylistic comments. |
|
Thanks for the feedback! My bad on the trailing spaces, I need to get my linter to check for that... I'll get the tweaks in and squashed shortly. |
without this, it's not possible to use UUID primary keys without uuid-ossp installed and activated
|
Ok, that should include everything mentioned above. Let me know if you see anything else. |
rafaelfranca
added a commit
that referenced
this pull request
May 1, 2013
Allow override of PostgreSQL UUID primary key default
|
Thank you |
rafaelfranca
added a commit
that referenced
this pull request
May 4, 2013
Allow override of PostgreSQL UUID primary key default
rafaelfranca
added a commit
that referenced
this pull request
May 4, 2013
Allow override of PostgreSQL UUID primary key default
rafaelfranca
added a commit
that referenced
this pull request
May 13, 2013
Allow override of PostgreSQL UUID primary key default
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Nov 2, 2015
pixeltrix
pushed a commit
that referenced
this pull request
Nov 2, 2015
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Jan 9, 2017
UUID primary key with no default value feature (rails#10404, rails#18206) was lost in legacy migration caused by rails#25395 got merged. Restore the feature again in legacy migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bc8ebef adds the ability to define tables with primary keys which use PostgreSQL's native UUID type, which is pretty sweet 馃槃.
However, because PostgreSQL does not itself provide a usable default value or UUID generator function, the
PostgreSQLAdapterimplementation sets the default value touuid_generate_v4(), which is a function provided by an external extension (uuid-ossp) that is not enabled by default in PostgreSQL (it is also not supported by some distributions of PostgreSQL鈥攏otably Heroku's Postgres.app).This default can currently only be overridden by either passing another UUID generation function (which will also not be enabled by default), or passing an actual static UUID value, which is not appropriate for a primary key.
This patch allows the
:defaultoption on a table definition to be set tonil, which will set no default value.Setting the default value to
nilwill require you to always generate a UUID before saving a record (likely in a model's or concern'sbefore_savecallback), but it will at least allow you to use the UUID primary key feature without extensions or external libraries.I also tried to add a little documentation that will hopefully help people looking into this in the future. Please let me know if you have any feedback or suggestions.
(Tagging @tenderlove, as this is the patch the he and I discussed in the rails-core mailing list.)