Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved grammar and replaced 'dbs' slang with 'databases' #10565

Merged
merged 1 commit into from
Jul 3, 2013

Conversation

prathamesh-sonpatki
Copy link
Member

No description provided.

@zzak
Copy link
Member

zzak commented May 11, 2013

I like "dbs" to "databases" but not so much the bit about portable schema
files

On Friday, May 10, 2013, प्रथमेश wrote:


You can merge this Pull Request by running

git pull https://github.com/prathamesh-sonpatki/rails rake-db

Or view, comment on, or merge it at:

#10565
Commit Summary

  • Improved grammar and replaced 'dbs' slang with 'databases'

File Changes

Patch Links:

@prathamesh-sonpatki
Copy link
Member Author

@zzak My first opinion was portable could be dropped altogether as db/schema.rb file that can be used against any DB supported by AR states that purpose very clearly.

@prathamesh-sonpatki
Copy link
Member Author

/cc @fxn

@prathamesh-sonpatki
Copy link
Member Author

@fxn Please review this.

@zzak
Copy link
Member

zzak commented May 14, 2013

Please be patient and wait for feedback, spamming is not acceptable

On Tue, May 14, 2013 at 11:35 AM, प्रथमेश notifications@github.com wrote:

@fxn https://github.com/fxn Please review this.


Reply to this email directly or view it on GitHubhttps://github.com//pull/10565#issuecomment-17884042
.

@fxn
Copy link
Member

fxn commented May 15, 2013

Hey, I am doing some other stuff in my free time these days, will come back soon.

@prathamesh-sonpatki
Copy link
Member Author

@fxn ping

@fxn
Copy link
Member

fxn commented May 28, 2013

Hey, you've ping'ed three times, I said I was off and when I am back I know this issue is pending together with others.

carlosantoniodasilva added a commit that referenced this pull request Jul 3, 2013
Improved grammar and replaced 'dbs' slang with 'databases'
@carlosantoniodasilva carlosantoniodasilva merged commit 9adbbe9 into rails:master Jul 3, 2013
@prathamesh-sonpatki prathamesh-sonpatki deleted the rake-db branch July 3, 2013 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants