Code cleanup for ActionDispatch::Flash#call

[julianvargasalvarez]

Here I include a fix for the broken specs in railties as reported here
#10580 (comment)

[julianvargasalvarez]

@guilleiguaran I ran the tests for Railties and actionpack and evenything is passing.

[rafaelfranca]

What happened with the env[KEY]?

[guilleiguaran]

Thank you

/cc @rubys how are your tests with this?

[julianvargasalvarez]

In line 244 the variable flash_hash was created with env[KEY] and then later inside the if that key was rewritten with flash_hash

[rafaelfranca]

I'm not seeing the key being rewritten

[julianvargasalvarez]

It was before. Check this out c43ca06#L0R245

in line 244 flash_hash = env[KEY] then in lines 249 and 241 new_hash = flash_hash and thin in line 254 env[KEY] = new_hash

[rafaelfranca]

Ok. But why it was removed?

[julianvargasalvarez]

Because that code seems to be unnecesary, I ran the tests for railties and actionpack and both are passing

[rubys]

/cc @rubys how are your tests with this?

👍

[rafaelfranca]

@julianvargasalvarez I'm not sure that code is unnecessary. The test coverage can not be accurate. I prefer to be conservative and merge the @arunagw fix. Thank you