Show real LoadError on helpers require #10642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| class InvalidHelpersTest < ActiveSupport::TestCase | ||
| def test_controller_raise_error_about_real_require_problem | ||
| assert_raise(LoadError, "No such file to load -- very_invalid_file_name") do |
There was a problem hiding this comment.
does this really verify the error message? As far as I know this only verifies the type of exception see the minitest source
to verify the message you can use:
e = assert_raise(LoadError) {}
assert_equal "No such file to load -- very_invalid_file_name", e.message
|
I added a few comments, can you also add a short CHANGELOG entry? |
|
@LTe ping, are you still on this PR? |
|
@senny yes, I will create update soon :) |
|
@senny updated |
|
@LTe it does no longer apply, can you push a rebased version? |
| @@ -1,3 +1,7 @@ | |||
| * Fix an issue where rails raise exception about missing helper where is should throw `LoadError`. When helper file exists and only loaded file from this helper does not exist rails should throw LoadError instead of MissingHelperError. | |||
There was a problem hiding this comment.
can you wrap this line to 80 chars?
|
@senny rebased and updated |
When helper try to require missing file rails will throw exception about
missing helper.
# app/helpers/my_helper.rb
require 'missing'
module MyHelper
end
And when we try do load helper
class ApplicationController
helper :my
end
Rails will throw exception. This is wrong because there is a helper
file.
Missing helper file helpers/my_helper.rb
Now when helper try to require non-existed file rails will throw proper
exception.
No such file to load -- missing
|
@LTe thanks for your contribution 💛 |
senny
added a commit
that referenced
this pull request
Jul 10, 2013
Show real LoadError on helpers require
senny
added a commit
that referenced
this pull request
Aug 28, 2013
Show real LoadError on helpers require Conflicts: actionpack/CHANGELOG.md Closes #12055.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When helper try to require missing file rails will throw exception about
missing helper.
And when we try do load helper
Rails will throw exception. This is wrong because there is a helper file.
Now when helper try to require non-existed file rails will throw proper exception.