Refactor AR's validations_test.rb #10662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,28 +14,30 @@ class ValidationsTest < ActiveRecord::TestCase | |||
| # Other classes we mess with will be dealt with in the specific tests | |||
| repair_validations(Topic) | |||
|
|
|||
| def test_error_on_create | |||
| def test_valid_question_uses_create_context_when_new_data | |||
There was a problem hiding this comment.
Not super-fond of this: took me a bit to parse what valid_question meant here.
There was a problem hiding this comment.
hmmm i c, what would u prefer than ? :D
|
@al2o3cr what do u think about this now? :D |
| assert r.save, "First save should be successful" | ||
|
|
||
| assert r.valid?, "First validation should be successful" | ||
| r.save |
There was a problem hiding this comment.
Just this change is not necessary, it'll run validations twice, you can use r.save in the assert call.
|
Changes look fine, added minor comments and please squash. Thanks. |
|
@carlosantoniodasilva thx! udpated and squashed and pushed 😄 |
| r = WrongReply.new | ||
| r.title = "Wrong Create" | ||
| assert !r.save | ||
| assert !r.valid? |
|
fixed and rebased master and force pushed 😃 the failing build is due to some connection problem |
The `:context` switch feature is implemented in ActiveRecord::Validations#valid? method, so we should rename the test names, and execute `valid?` in the test. Change test name in AR's validations_test.rb This test is testing save method's code
carlosantoniodasilva
added a commit
that referenced
this pull request
May 11, 2014
…--Validations#valid- Refactor AR's validations_test.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactoring, tell me anything if u thought something about this PR :D