Fix doc in Postgres database creation #10664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,6 +49,7 @@ def recreate_database(name, options = {}) #:nodoc: | |||
| # <tt>:encoding</tt>, <tt>:collation</tt>, <tt>:ctype</tt>, | |||
| # <tt>:tablespace</tt>, and <tt>:connection_limit</tt> (note that MySQL uses | |||
| # <tt>:charset</tt> while PostgreSQL uses <tt>:encoding</tt>). | |||
| # Encoding defaults to utf8. | |||
There was a problem hiding this comment.
maybe add it in perenthesis after the option:
<tt>:encoding</tt> (defaults to utf8), ...
|
@aderyabin ping, did you have time to make the proposed change? |
|
I'll do it today. |
senny
added a commit
that referenced
this pull request
Oct 29, 2013
Fix doc in Postgres database creation [ci skip]
|
@aderyabin sorry for the long waiting time. GitHub does not notify when you push new commits to a PR. It's always good to also add a comment so relevant people are notified. Thanks for your contribution 💛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default encoding for new Postgres database is utf8 and it has assert but not pointed in doc.