Remove attributes_protected_by_default reference

[robertomiranda]

Remove attributes_protected_by_default reference, since MassAssignmentSecurity was removed from ActiveModel f8c9a4d

[rafaelfranca]

Should not this be keep for those who want to use the prottectd_attributes gem? Or at least be moved to it?

[guilleiguaran]

👍 for move to protected_attributes gem, looks like the right place for it

[guilleiguaran]

Note for mergers: please don't merge this until it's added to protected_attributes gem 😁

[carlosantoniodasilva]

@guilleiguaran can we get this in? :)

[guilleiguaran]

mmm, we will continue supporting protected_attributes after of release of Rails 4.1?

[carlosantoniodasilva]

I think we will support it until 5.

[robertomiranda]

@carlosantoniodasilva @guilleiguaran can we get this merged considering that Rails 4.1 and 4.2 have been released?

[carlosantoniodasilva]

We can, but I'd prefer to merge a single PR removing all references. Would you want to work on that or can I go ahead and do it? :)

[robertomiranda]

@carlosantoniodasilva I would like too, but I'll leave you the decision on your hands 😄

[guilleiguaran]

iirc, that's the unique place where we have references about attributes_protected_by_default, I removed all others during StrongParameters merge 😄

[guilleiguaran]

ack confirms:

~/src/rails[master] % ack attributes_protected_by_default
activemodel/lib/active_model/secure_password.rb
82:        if respond_to?(:attributes_protected_by_default)
83:          def self.attributes_protected_by_default #:nodoc:

[robertomiranda]

@guilleiguaran 👍

[carlosantoniodasilva]

I meant protected_attributes in general 😄

$ ack protected_attributes
activemodel/lib/active_model/secure_password.rb
81:        # This code is necessary as long as the protected_attributes gem is supported.

activerecord/lib/active_record/core.rb
284:      # +options+ argument is only needed to make protected_attributes gem easier to hook.
560:    # This method is needed to make protected_attributes gem easier to hook.

I'll clean those ones. Thanks <3