ActiveSupport::StringInquirer does a regexp check instead of direct match

[itsmeduncan]

This adds the convenience of allowing developers to continue to use the simple boolean check on multiple environments. We use parallel_spec which creates test[1..4], breaking our .test? assumptions. This fixes that issue by doing a regexp check on the string.

RAILS_ENV=test
Rails.env.test? #=> true

RAILS_ENV=test1
Rails.env.test? #=> true

[tomafro]

I would expect StringInquirer to return true only when given a full match. While the example you've provided almost makes sense to me (as the range of environments is likely to be limited), there are many other uses for it other than environment checking. To get the behaviour you want, to me Rails.env.starts_with?("test") is both more explicit and more correct.

[josevalim]

I agree with @tomafro. It may make sense for Rails.env, but that would totally break all other use cases for StringInquirier.