include? in ActiveRecord::Associations::CollectionProxy return 1 instead of true

[achiinto]

Foo has_many Bars
Foo.first.bars.include? bar

If false, it returns false
If true, it returns 1

When I do this,

the_bars = Foo.first.bars
the_bars.include? bar

if true, it returns true.

I am reproducing this in Rails 4.

[senny]

I'll take a look.

[senny]

I can confirm this behavior, I rewrote the has_many_association tests with the following result

HasManyAssociationsTest#test_include_checks_if_record_exists_if_target_not_loaded [test/cases/associations/has_many_associations_test.rb:1379]:
Expected: true
  Actual: 1


  2) Failure:
HasManyAssociationsTest#test_include_returns_false_for_non_matching_record_to_verify_scoping [test/cases/associations/has_many_associations_test.rb:1401]:
Expected: false
  Actual: nil


  3) Failure:
HasManyAssociationsTest#test_included_in_collection [test/cases/associations/has_many_associations_test.rb:1223]:
Expected: true
  Actual: 1

[senny]

I did some research and it's enough if question mark methods return a truthy or falsy value. you can read more on that discussion on this PR: #5329

I'm closing this one as the described behavior is alright. Thanks for reporting 💛

[fxn]

This one may be different, because this predicate for whatever reason documents that the singleton true is returned (it is not the way we normally document predicates).

I would revise in this case the return value to keep backwards compatibility (instead of relaxing the contract).

[senny]

@fxn thanks, I'm on it.

[fxn]

👍