Fixed ActiveModel::Model's inclusion chain #11004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
pushed a commit
that referenced
this pull request
Jun 19, 2013
…-fix Fixed ActiveModel::Model's inclusion chain
|
Sorry for bad English. This commit will raise error if there no ancestors. e3dc10f#commitcomment-3457605 |
|
Yes, @fredwu could you check this |
|
I'm already on it. :) |
fredwu
added a commit
to fredwu/rails
that referenced
this pull request
Jun 19, 2013
fredwu
added a commit
to fredwu/rails
that referenced
this pull request
Jun 19, 2013
This was referenced Jun 19, 2013
|
Fixed in #11010 and #11011. cc @rafaelfranca @woto |
fredwu
added a commit
to fredwu/rails
that referenced
this pull request
Jun 19, 2013
josevalim
pushed a commit
that referenced
this pull request
Jun 19, 2013
Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
josevalim
pushed a commit
that referenced
this pull request
Jun 19, 2013
Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
josevalim
pushed a commit
that referenced
this pull request
Jun 19, 2013
Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
|
New problem with last commit on ActiveModel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @josevalim @drogus
master version #11002