Asking user to declare post resource in getting start guide #11127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add [ci skip] in commit message also? And force push again? |
|
@arunagw done |
| Rails provides a `resources` method which can be used to declare a | ||
| standard REST resource. Here's how `config/routes.rb` will look like. | ||
| Rails provides a `resources` method which can be used to declare a standard REST resource. | ||
| Here's how `config/routes.rb` should look like after _post resource_ is declared. |
There was a problem hiding this comment.
Something about this sentence sounds very strange to me, but I can't put my finger on it. Let's see what @fxn thinks.
There was a problem hiding this comment.
It sounds better to me if you change "how" to "what" so it reads:
Here's what config/routes.rb should look like after the post resource is declared.
There was a problem hiding this comment.
It was also missing a "the".
There was a problem hiding this comment.
@alexrothenberg @davidcelis thanks, I have added fixes
|
@pftg can you please squash the commits? |
|
@senny done! |
senny
added a commit
that referenced
this pull request
Jun 27, 2013
…s_in_guide Asking user to declare post resource in getting start guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11122
Changed getting start guide to ask to add
resources :postintoconfig/routes.rb/cc @senny