updated AS:Callbacks docs, variable namings #11195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod The change is commited at ba55276
|
Can you squash the last 2 commits at least? The doc commit is fine to be on its own. Thanks. |
_ Rename the define_callbacks params to `names` - in order to match the naming conventions for `get_callbacks` and `set_callbacks` at https://github.com/rails/rails/blob/master/activesupport/lib/active_support/callbacks.rb#L736-743 - `define_callbacks` just register names(events), not define the real callback functions. - Rename the `reset_callbacks` params
|
@carlosantoniodasilva commits squashed. BTW, does |
|
@yangchenyun exactly what @zhouguangming linked: you can use |
carlosantoniodasilva
added a commit
that referenced
this pull request
Jul 1, 2013
…backs updated AS:Callbacks docs, variable namings
|
@zhouguangming Thanks 👍 |
gsamokovarov
added a commit
to gsamokovarov/rails
that referenced
this pull request
Jul 1, 2013
In rails#11195 I noticed a trailing comma in the docs, but I decided to further clean it up. What I have done: * Clean up the trailing comma in the docs and some extra whitespace lines. * Used `Array#extract` options to factor the repetitive pattern of `args.last.is_a(Hash) ? ...` * Renamed the local var `config` to `options` in `define_callbacks`, as `options` seems to be the de facto name for the options objects. * Renamed the local var `l` to `line` in `define_callback` (maybe it meant `lambda` in the context) as single `l` may look like `1` in some fonts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namesget_callbacksandset_callbacksat https://github.com/rails/rails/blob/master/activesupport/lib/active_support/callbacks.rb#L736-743define_callbacksjust register names(events), not define the real callback functions.