Some performance benchmarking for take vs limit #11336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| x.report 'Model.take!' do | ||
| Exhibit.take |
There was a problem hiding this comment.
Well ideally it should be take vs limit. As both form the same LIMIT sql. I was checking the BM of take and take! also if there is a overhead. I think we can remove take!
|
@rafaelfranca removed take! |
|
Could you squash your commits please? |
Also added a dummy progress bar during insert of records so it shows something is happening.
Performance report
Model.take 6198.9 (±13.4%) i/s - 121743 in 20.042671s
Model.take! 6173.6 (±13.6%) i/s - 121242 in 20.057006s
Model.all limit(100) 107.8 (±15.8%) i/s - 2106 in 20.022316s
Model.all take(100) 105.2 (±15.2%) i/s - 2061 in 20.062509s
|
@rafaelfranca Done 👍 |
rafaelfranca
added a commit
that referenced
this pull request
Jul 6, 2013
Some performance benchmarking for take vs limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a dummy progress bar during insert of records so it shows something is happening.
Performance report