Update of 'The Asset Pipeline' guide for Rails 4. #11358
Conversation
|
@steveklabnik @guilleiguaran can you guys take a look? |
|
Hey @senny I had some problems working with Git earlier, hopefully those guys will still want to look at it. I think it is done now and looking pretty good. Thanks. |
|
@Alamoz if you have another PR please link id using |
|
Cool, thanks @senny |
| The asset pipeline provides a framework to concatenate and minify or compress JavaScript and CSS assets. It also adds the ability to write these assets in other languages such as CoffeeScript, Sass and ERB. | ||
| The asset pipeline provides a framework to concatenate and minify or compress | ||
| JavaScript and CSS assets. It also adds the ability to write these assets in | ||
| other languages such as CoffeeScript, Sass and ERB. | ||
|
|
There was a problem hiding this comment.
Maybe "markup" or "pre-processor" would be more exact instead of "language", no?
There was a problem hiding this comment.
Changed it to "...other languages and pre-processors..." since js and CoffeeScript definitely qualify as languages (with CoffeeScript also qualifying as a pre-processor,) while SASS and ERB are more commonly thought of as pre-processed types of expression.
|
Very nice pull request @Alamoz. I've added some comments with @guilleiguaran and @lucasmazza. Thanks a lot! Maybe some of mine need an approval. |
|
Hey @robin850, I'll make those changes by tomorrow morning. I'm getting ready for a Rails installfest and don't have much time until late tonight. |
|
Thanks @guilleiguaran and @robin850 for the help. I've made all the suggested changes. Let me know if there is anything else. I'm not sure how close you are to the next release, but this should help people upgrading to Rails 4 so we can always add more later if you want to elaborate in more detail. |
|
@Alamoz : Awesome! Thanks! ❤️ @guilleiguaran : LGTM |
|
@fxn : Sorry to ping your one more time but could you have a look please? 😃 |
|
No worries, thanks for reminding me, I'll try to have a look today. |
|
@Alamoz awesome patch, thanks very much. |
Update of 'The Asset Pipeline' guide for Rails 4.
Update asset pipeline guide for Rails 4. Includes numerous grammatical changes.