Fix FinderMethods#exists? sql generation to make picky sql servers happy - 3 0 stable #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s SQLServer and others happy that do not like columns without an alias.
|
+1 please fix |
|
@iaddict Is this still an issue? If not, please close it. Thanks. |
|
This pull request is for a no longer supported Rails version. If you still have this issue please open a new pull request pointing to master. Thank you so much for your time. |
rafaelfranca
added a commit
that referenced
this pull request
Jun 10, 2012
rafaelfranca
added a commit
that referenced
this pull request
Jun 10, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal change to query generation of FinderMethods#exists? that makes SQLServer and others happy that do not like columns without an alias.
Without this patch MS-SQLServer doesn't like the generated SQL and barks for FinderMethods#exists?, ie:
ActiveRecord::StatementInvalid: ActiveRecord::JDBCError: No column was specified for column 2 of 't'.: SELECT t.* FROM (SELECT ROW_NUMBER() OVER(ORDER BY huhu.id) AS _row_num, 1 FROM huhu WHERE huhu.[id] = 83287) AS t WHERE t._row_num BETWEEN 1 AND 1